Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cachedKeyDecoder configurable #85

Merged
merged 2 commits into from
Aug 30, 2019
Merged

Conversation

sergeyzenchenko
Copy link
Collaborator

No description provided.

@sergeyzenchenko sergeyzenchenko requested a review from gfx August 30, 2019 08:58
@gfx
Copy link
Member

gfx commented Aug 30, 2019

I think making keyDecoder configurable is better, where you can set a null key decoder that does nothing.

@sergeyzenchenko
Copy link
Collaborator Author

hm actually, yeah maybe it will be better. I just wanted to hide it from public API

@codecov-io
Copy link

codecov-io commented Aug 30, 2019

Codecov Report

Merging #85 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #85   +/-   ##
=======================================
  Coverage   98.33%   98.33%           
=======================================
  Files          16       16           
  Lines         962      962           
  Branches      195      196    +1     
=======================================
  Hits          946      946           
  Misses         16       16
Impacted Files Coverage Δ
src/Decoder.ts 99.13% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 695f3b4...3286fa2. Read the comment docs.

@sergeyzenchenko sergeyzenchenko merged commit d4ebde1 into master Aug 30, 2019
@sergeyzenchenko sergeyzenchenko deleted the cached-key-decoder-flag branch August 30, 2019 10:35
@gfx gfx changed the title Add flag for cachedKeyDecoder usage Make cachedKeyDecoder configurable Aug 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants